Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit goes to Palni Palci for pointing out this bug + contributing the fix back.
Summary
On the Collection show page, the sort_by dropdown button was not working. A user could select and option and a request would be made, but the sort params was not making it through to the search builder and therefore did not sort the items regardless of the selection.
Accepted Criteria
Testing Instructions
Detailed Description
DEMO
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers