Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection sort by drop down #6408

Merged
merged 4 commits into from Nov 2, 2023
Merged

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Nov 1, 2023

Credit goes to Palni Palci for pointing out this bug + contributing the fix back.

Summary

On the Collection show page, the sort_by dropdown button was not working. A user could select and option and a request would be made, but the sort params was not making it through to the search builder and therefore did not sort the items regardless of the selection.

Accepted Criteria

  • sort options are functional for collection show page

Testing Instructions

  • Login in as an admin user
  • Click on Collections. Find a collection with several works and click on it. Click to see the public view of it.
  • Change the selections of the sort_by drop down. The works' orders should change accordingly.

Detailed Description

DEMO

Changes proposed in this pull request:

  • Pass sort selection through the controller and onto the search builder to make it work.

@samvera/hyrax-code-reviewers

On the Collection show page, the sort_by dropdown button was not working. A user could select and option and a request would be made, but the sort params was not making it through to the search builder and therefore did not sort the items regardless of the selection.
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Nov 1, 2023

image

ref slack convo about this: https://samvera.slack.com/archives/C0F9JQJDQ/p1698848505345209

TODO: Add spec

@ShanaLMoore ShanaLMoore marked this pull request as ready for review November 1, 2023 15:34
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Nov 2, 2023
Copy link
Contributor

@dlpierce dlpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll make a note to add a test for this while converting it for valkyrie.

@dlpierce dlpierce merged commit a5e91e7 into main Nov 2, 2023
4 checks passed
@dlpierce dlpierce deleted the fix-collection-sort-by-drop-down branch November 2, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants