Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkyrize collection feature spec #6412

Merged
merged 2 commits into from Nov 3, 2023
Merged

Valkyrize collection feature spec #6412

merged 2 commits into from Nov 3, 2023

Conversation

dlpierce
Copy link
Contributor

@dlpierce dlpierce commented Nov 2, 2023

Summary

Convert collection feature spec to valkyrie resources, add sorting spec; ref #6408

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Collection json response is correct; id is id: 'abc123', not a hash like id: { id: 'abc123' }

Changes proposed in this pull request:

  • Use hyrax/base/show jbuilder partial for collection json response format.

@samvera/hyrax-code-reviewers

@dlpierce dlpierce added notes-valkyrie Release Notes: Valkyrie specific notes-bugfix Release Notes: Fixed a bug labels Nov 2, 2023
@dlpierce dlpierce merged commit 3e3e134 into main Nov 3, 2023
4 checks passed
@dlpierce dlpierce deleted the valk-col-feat-spec branch November 3, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug notes-valkyrie Release Notes: Valkyrie specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants