♻️ Extracting naming container #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throughout the code we have quite a bit of conditionals regarding what is a work, collection, file_set, and adminsitrative set. This model attempts to provide a common point to interrogate the application. There are, at present, no refactors to use this model. Consider how our specs and our application are inconsistent in their declaration/configuration/stubbing. This model should help with that.
Instead of the myriad of ways of asking about which models to use, let's leverage a consolidated central place for information. This is but one step in addressing other issues.
For those reading along, I removed an assertion from `spec/features/dashboard/collection_spec.rb`. Why? Because the test was creating one type of admin set, and the queries for what to show was filtering on other kinds of admin sets. Ultimatley creating a false assertion.
jeremyf
force-pushed
the
extract-hyrax-model-registry
branch
from
108abdb
to
30bc9e1
Compare
Prior to this commit, if the `update` failed, we would not have set the
`@collection_type` instance variable. Which would mean that we'd raise
a `NoMethodError` on `NilClass` in the
`app/views/hyrax/dashboard/collections/_form_share_table.html.erb` view.
By favoring a helper method, we no longer require that the edit (nor
create) call the collection_type method.
Below is the the only view references for `@collection_type`, so the
helper_method appears to be adequate.
```shell
❯ rg "@collection_type[\. ]" app/views
app/views/hyrax/dashboard/collections/_form_share_table.html.erb
5: <p><%= t(".#{access}.help_with_works", type_title: @collection_type.title) if @collection_type.share_applies_to_new_works? && access != 'depositors' %></p>
app/views/hyrax/admin/collection_types/_form.html.erb
22: <% if @collection_type.admin_set? %>
```
jeremyf
commented
Feb 14, 2024
dlpierce
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throughout the code we have quite a bit of conditionals regarding what is a work, collection, file_set, and adminsitrative set. This model attempts to provide a common point to interrogate the application.
There are, at present, no refactors to use this model.
Consider how our specs and our application are inconsistent in their declaration/configuration/stubbing. This model should help with that.
@samvera/hyrax-code-reviewers