New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Extracting naming container #6694
Merged
Merged
Commits on Feb 13, 2024
-
♻️ Extracting naming container
Throughout the code we have quite a bit of conditionals regarding what is a work, collection, file_set, and adminsitrative set. This model attempts to provide a common point to interrogate the application. There are, at present, no refactors to use this model. Consider how our specs and our application are inconsistent in their declaration/configuration/stubbing. This model should help with that.
Configuration menu - View commit details
-
Copy full SHA for 929bb09 - Browse repository at this point
Copy the full SHA 929bb09View commit details -
♻️ Favor Hyrax::ModelRegistry for search builders
Instead of the myriad of ways of asking about which models to use, let's leverage a consolidated central place for information. This is but one step in addressing other issues.
Configuration menu - View commit details
-
Copy full SHA for ed3b954 - Browse repository at this point
Copy the full SHA ed3b954View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52b1f65 - Browse repository at this point
Copy the full SHA 52b1f65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5597e2a - Browse repository at this point
Copy the full SHA 5597e2aView commit details -
For those reading along, I removed an assertion from `spec/features/dashboard/collection_spec.rb`. Why? Because the test was creating one type of admin set, and the queries for what to show was filtering on other kinds of admin sets. Ultimatley creating a false assertion.
Configuration menu - View commit details
-
Copy full SHA for 30bc9e1 - Browse repository at this point
Copy the full SHA 30bc9e1View commit details
Commits on Feb 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bf67a8c - Browse repository at this point
Copy the full SHA bf67a8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6331a3 - Browse repository at this point
Copy the full SHA d6331a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02636f9 - Browse repository at this point
Copy the full SHA 02636f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c28355 - Browse repository at this point
Copy the full SHA 5c28355View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8db609 - Browse repository at this point
Copy the full SHA b8db609View commit details -
Configuration menu - View commit details
-
Copy full SHA for 047df15 - Browse repository at this point
Copy the full SHA 047df15View commit details -
🐛 Favor helper method over instance variable
Prior to this commit, if the `update` failed, we would not have set the `@collection_type` instance variable. Which would mean that we'd raise a `NoMethodError` on `NilClass` in the `app/views/hyrax/dashboard/collections/_form_share_table.html.erb` view. By favoring a helper method, we no longer require that the edit (nor create) call the collection_type method. Below is the the only view references for `@collection_type`, so the helper_method appears to be adequate. ```shell ❯ rg "@collection_type[\. ]" app/views app/views/hyrax/dashboard/collections/_form_share_table.html.erb 5: <p><%= t(".#{access}.help_with_works", type_title: @collection_type.title) if @collection_type.share_applies_to_new_works? && access != 'depositors' %></p> app/views/hyrax/admin/collection_types/_form.html.erb 22: <% if @collection_type.admin_set? %> ```
Configuration menu - View commit details
-
Copy full SHA for 6907fd9 - Browse repository at this point
Copy the full SHA 6907fd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d7579 - Browse repository at this point
Copy the full SHA 28d7579View commit details -
Configuration menu - View commit details
-
Copy full SHA for c56dcb9 - Browse repository at this point
Copy the full SHA c56dcb9View commit details
Commits on Feb 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bb72baa - Browse repository at this point
Copy the full SHA bb72baaView commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9044f7a - Browse repository at this point
Copy the full SHA 9044f7aView commit details
Commits on Feb 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 95da3a7 - Browse repository at this point
Copy the full SHA 95da3a7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.