Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Extracting naming container #6694

Merged
merged 17 commits into from Feb 18, 2024
Merged

♻️ Extracting naming container #6694

merged 17 commits into from Feb 18, 2024

Commits on Feb 13, 2024

  1. ♻️ Extracting naming container

    Throughout the code we have quite a bit of conditionals regarding what
    is a work, collection, file_set, and adminsitrative set.  This model
    attempts to provide a common point to interrogate the application.
    
    There are, at present, no refactors to use this model.
    
    Consider how our specs and our application are inconsistent in their
    declaration/configuration/stubbing.  This model should help with that.
    jeremyf committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    929bb09 View commit details
    Browse the repository at this point in the history
  2. ♻️ Favor Hyrax::ModelRegistry for search builders

    Instead of the myriad of ways of asking about which models to use, let's
    leverage a consolidated central place for information.
    
    This is but one step in addressing other issues.
    jeremyf committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    ed3b954 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    52b1f65 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5597e2a View commit details
    Browse the repository at this point in the history
  5. ♻️ Favor Hyrax::ModelRegistry

    For those reading along, I removed an assertion from
    `spec/features/dashboard/collection_spec.rb`.  Why?  Because the test
    was creating one type of admin set, and the queries for what to show was
    filtering on other kinds of admin sets.
    
    Ultimatley creating a false assertion.
    jeremyf committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    30bc9e1 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. ♻️ Fixing spec

    jeremyf committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    bf67a8c View commit details
    Browse the repository at this point in the history
  2. Adding case statement

    jeremyf committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d6331a3 View commit details
    Browse the repository at this point in the history
  3. ☑️ Fix stubbing

    jeremyf committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    02636f9 View commit details
    Browse the repository at this point in the history
  4. ♻️ Favor helper method

    jeremyf committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    5c28355 View commit details
    Browse the repository at this point in the history
  5. ♻️ Favor dynamic value

    jeremyf committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    b8db609 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    047df15 View commit details
    Browse the repository at this point in the history
  7. 🐛 Favor helper method over instance variable

    Prior to this commit, if the `update` failed, we would not have set the
    `@collection_type` instance variable.  Which would mean that we'd raise
    a `NoMethodError` on `NilClass` in the
    `app/views/hyrax/dashboard/collections/_form_share_table.html.erb` view.
    
    By favoring a helper method, we no longer require that the edit (nor
    create) call the collection_type method.
    
    Below is the the only view references for `@collection_type`, so the
    helper_method appears to be adequate.
    
    ```shell
    ❯ rg "@collection_type[\. ]" app/views
    app/views/hyrax/dashboard/collections/_form_share_table.html.erb
    5:  <p><%= t(".#{access}.help_with_works", type_title: @collection_type.title) if @collection_type.share_applies_to_new_works? && access != 'depositors' %></p>
    
    app/views/hyrax/admin/collection_types/_form.html.erb
    22:      <% if @collection_type.admin_set? %>
    ```
    jeremyf committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6907fd9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    28d7579 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c56dcb9 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Configuration menu
    Copy the full SHA
    bb72baa View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    9044f7a View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. 🧹 An empty commit

    jeremyf committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    95da3a7 View commit details
    Browse the repository at this point in the history