-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Points Hyrax::EditPermissionsService.build_service_object_from to Hyrax configuration variable. #6768
base: main
Are you sure you want to change the base?
Points Hyrax::EditPermissionsService.build_service_object_from to Hyrax configuration variable. #6768
Conversation
…ax configuration variable. For L#44, the `if` test's subject is hard-coded and unaware of any customized form class that the Hyrax Engine's implementers could create and set inside the Engine's configuration. This swaps to the configuration variable that defaults to the same hard-coded class (`Hyrax::Forms::FileSetForm`).
e021d1a
to
196fdcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Test Results 17 files ±0 17 suites ±0 2h 19m 0s ⏱️ - 2m 26s Results for commit 196fdcf. ± Comparison against base commit 59a42ad. This pull request removes 272 and adds 272 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Summary
Points Hyrax::EditPermissionsService.build_service_object_from to Hyrax configuration variable.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
*This change should not alter any tested processing.
Type of change (for release notes)
notes-bugfix
Bug Fixesnotes-valkyrie
Valkyrie ProgressDetailed Description
For L#44, the
if
test's subject is hard-coded and unaware of any customized form class that the Hyrax Engine's implementers could create and set inside the Engine's configuration. This swaps to the configuration variable that defaults to the same hard-coded class (Hyrax::Forms::FileSetForm
).@samvera/hyrax-code-reviewers