-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent sharing works and filesets with unintended groups #6823
Open
davidcam-src
wants to merge
12
commits into
main
Choose a base branch
from
group-sharing-safeguards
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… options to restrict the visibility options provided to the user Closes #6822
Test Results 17 files ±0 17 suites ±0 2h 18m 10s ⏱️ +53s Results for commit 3562ca7. ± Comparison against base commit 891cdb5. This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6822
Summary
Guidance for testing:
Criteria: Users should not be able to share works to groups outside of the visibility restrictions of the admin set it belongs to
Criteria: Users should not be able to share works to groups outside of the visibility restrictions of the admin set it belongs to
Changes proposed in this pull request:
file_set_admin_set_option
function added to retrieve the admin set for any given fileadmin_set_options
partial added topermission.html.erb
to ensure the permissions control javascript executes, only renders for non-admins so that admins can still easily override sharing restrictions imposed by admin setscurrent_user.groups
inpermission_form.html.erb
withavailable_user_groups
function call@samvera/hyrax-code-reviewers