Grab the label from the file_set import URL #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May depend on samvera/browse-everything#167 (also WIP) |
mjgiarlo
force-pushed
the
grab_label_from_import_url_hyku/1021
branch
from
447cec7
to
b48cc4b
Compare
mjgiarlo
changed the title
mjgiarlo
commented
May 9, 2017
| @@ -39,7 +39,7 @@ def validate_files(files, env) | |||
| # @return [TrueClass] | |||
| def attach_files(files, env) | |||
| return true unless files | |||
| AttachFilesToWorkJob.perform_later(env.curation_concern, files) | |||
| AttachFilesToWorkJob.perform_later(env.curation_concern, files, env.attributes.to_h.symbolize_keys) | |||
There was a problem hiding this comment.
The new arg here does what line 43 of the AttachFilesActor did. It makes sure that e.g. embargo attrs are available for FileSets in the actor stack.
mjgiarlo
commented
May 9, 2017
| @@ -31,10 +31,9 @@ def perform(file_set, operation) | |||
| # on a machine that did not have this temp file on it's file system. | |||
| # NOTE: The return status may be successful even if the content never attaches. | |||
| if Hyrax::Actors::FileSetActor.new(file_set, user).create_content(f, 'original_file', false) | |||
| # send message to user on download success | |||
| Hyrax.config.callback.run(:after_import_url_success, file_set, user) | |||
There was a problem hiding this comment.
Don't bother sending a notification if the import succeeded. User will already get notified when the FileSet is attached to the Work.
mjgiarlo
force-pushed
the
grab_label_from_import_url_hyku/1021
branch
from
f6ef2f1
to
d144920
Compare
|
@jcoyne This is ready for review, good sir. |
jcoyne
approved these changes
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
AttachFilesActorwhich has been subsumed byCreateWithFilesActorandAttachFilesToWorkJob.Fixes samvera/hyku#1021