Update RSolr exception class stubbing for rsolr 2.0 #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd also entertain objections that this is an upstream problem in Blacklight with RSolr 2.x. I'm not completely convinced the distinction rsolr 1.x made between socket errors and http errors is all that useful, though. |
jcoyne
reviewed
May 9, 2017
| @@ -35,14 +35,14 @@ def fetch_admin_sets | |||
| .rows(5) | |||
| response = repository.search(builder) | |||
| response.documents | |||
| rescue Blacklight::Exceptions::ECONNREFUSED | |||
| rescue Blacklight::Exceptions::ECONNREFUSED, Blacklight::Exceptions::InvalidRequest | |||
There was a problem hiding this comment.
Can the existing error go away if we use RSolr 2? If so, can you add a comment about this.
There was a problem hiding this comment.
Depends whether we try to fix this in Blacklight or not.
|
This should fix the RSolr regression: rsolr/rsolr#176 |
mjgiarlo
approved these changes
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.