Remove 4.2 support #155
Merged
Remove 4.2 support #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elrayle
commented
Sep 25, 2017
elrayle
commented
- update gemspec to require at least Rails 5.0
- update Travis to test Rails 5.0 and 5.1
elrayle
force-pushed
the
remove_4.2_support
branch
from
5357cdb
to
5a4fae1
Compare
no-reply
reviewed
Sep 25, 2017
README.md
Outdated
| @@ -634,7 +634,7 @@ Commit your features into a new branch and submit a pull request. | |||
|
|
|||
| ## Compatibility | |||
|
|
|||
| Currently, it is compatible with Rails 4.0 and 4.1 under both Ruby 2.0 and 2.1. | |||
| Currently, it is compatible with Rails 5.0 and 5.1 under both Ruby 2.4.1. | |||
There was a problem hiding this comment.
Can we add Ruby 2.3 to the test matrix and to this README?
Otherwise, remove the word "both"
no-reply
reviewed
Sep 25, 2017
qa.gemspec
Outdated
| @@ -17,7 +17,7 @@ Gem::Specification.new do |s| | |||
| s.files = Dir["{app,config,db,lib}/**/*", "LICENSE", "Rakefile", "README.md"] | |||
| s.test_files = Dir["spec/**/*"] | |||
|
|
|||
| s.add_dependency "rails", ">= 4.2.0", "< 6.0" | |||
| s.add_dependency "rails", "~> 5.0", "< 6.0" | |||
elrayle
force-pushed
the
remove_4.2_support
branch
from
337d4ec
to
f4a59e6
Compare
elrayle
force-pushed
the
remove_4.2_support
branch
from
f4a59e6
to
e869ec8
Compare
no-reply
approved these changes
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.