Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 4.2 support #155

Merged
merged 3 commits into from
Sep 25, 2017
Merged

Remove 4.2 support #155

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00eecbd
Remove support for Rails 4.2
elrayle Sep 25, 2017
5a4fae1
Update Travis to test Rails 5.1.4
elrayle Sep 25, 2017
e869ec8
Change from hydra-tech to samvera-tech
elrayle Sep 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
language: ruby
sudo: false
rvm:
- 2.4.0
- 2.4.1
env:
global:
- NOKOGIRI_USE_SYSTEM_LIBRARIES=true
matrix:
- "RAILS_VERSION=5.0.1"
- "RAILS_VERSION=5.0.6"
- "RAILS_VERSION=5.1.4"

before_install:
- gem update --system
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ Commit your features into a new branch and submit a pull request.

## Compatibility

Currently, it is compatible with Rails 4.0 and 4.1 under both Ruby 2.0 and 2.1.
Currently, it is compatible with Rails 5.0 and 5.1 under both Ruby 2.4.1.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add Ruby 2.3 to the test matrix and to this README?

Otherwise, remove the word "both"


# Help

Expand Down
2 changes: 1 addition & 1 deletion qa.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Gem::Specification.new do |s|
s.files = Dir["{app,config,db,lib}/**/*", "LICENSE", "Rakefile", "README.md"]
s.test_files = Dir["spec/**/*"]

s.add_dependency "rails", ">= 4.2.0", "< 6.0"
s.add_dependency "rails", "~> 5.0", "< 6.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "< 6.0" as redundant?

s.add_dependency "faraday"
s.add_dependency "nokogiri", "~> 1.6"
s.add_dependency "activerecord-import"
Expand Down