Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for and test Fedora 6. #853

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Add support for and test Fedora 6. #853

merged 3 commits into from
Apr 22, 2021

Conversation

tpendragon
Copy link
Collaborator

@tpendragon tpendragon commented Apr 20, 2021

No description provided.

@escowles
Copy link
Contributor

Do we have a particular dedication to using an ID with a slash in the failing test? That's not in a shared spec or any of the other implementations. And using an ID with a slash creates a weird missing node in Fedora 6 — we could fix the test so that creating "http://localhost:8978/fcrepo/rest/test_fed/test/default" would work, but "http://localhost:8978/fcrepo/rest/test_fed/test" would not exist, so I'm not sure what the point of having the slash in the ID would be.

@tpendragon
Copy link
Collaborator Author

tpendragon commented Apr 20, 2021

@escowles It's so long ago. I'm assuming this was in direct response to creating admin sets, where the ID has to come back in Valkyrie as "default/admin_set", as per #313. I'm pretty hesitant to change the test. If you're up for investigating, if it turns out in Fedora 4/5 that it creates a node with an ID of "test/default" then maybe we can change the implementation to not CGI escape, but rather just consider everything after the prefix as the Valkyrie ID.

@escowles escowles merged commit 1d5515f into main Apr 22, 2021
@escowles escowles deleted the fedora-6 branch April 22, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants