-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give users the option to add symbols #55
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1660711
Give users the option to add symbols
technetium 6ac49fa
Set the title of the symbol to the name
technetium 261541d
Bugfix: Correcting isEditingSymbol function
technetium 26eee1c
Make symbols draggable
technetium 3f6a84f
Use 2 spaces for indentation in ccs
technetium 679f25d
Use 2 spaces for indentation in ccs
technetium 6341e7c
This works (kind of)
technetium 914415c
Implemented suggestions by @samwho
technetium 240e9db
Merge branch 'samwho:main' into main
technetium 872fd70
Bugfixes
technetium b916854
Make it possible to use the delete key to delete symbols
technetium 5f9c092
Bugfix: Order of operators is difficult
technetium 7d65df1
Bugfix: Use the glyph in the data, not the HTML-escaped content
technetium 1964594
Merge branch 'samwho:main' into main
technetium 911e11b
Merge branch 'samwho:main' into main
technetium File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about this earlier today: what happens when the default symbols are updated? I think currently the user won't see them, they'll load what's in local storage and completely ignore the defaults.
We probably need some sort of merging. Alternately, we track users' custom symbols separately to the defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to merge new defaults, with the existing symbols, we need to label either the user symbols or the defaults (which adds complexity) and then disable the editing of the defaults (which adds complexity) then it will be impossible for users to move the frequently used default symbols to the top of the list, resulting in users that will add existing default symbols also to the user symbols. Reducing the benefits of a list of default symbols.
Another method is to track all the changes made by the user (which adds way more complexity) and apply them every time the defaults are loaded (which is so complex I cannot imagine how to do that)
If you can program that, you're welcome to do that. I probably don't have the knowledge, and if I did my time is also limited.
Another solution would be to publish sets of symbols, including a default. When a set (e.g. the default set) is updated let the user load that set into their collection. That's something I could implement in a few hours. As a matter of fact, I already did. It's in pull request #59