Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed execa dependency #27

Merged
merged 7 commits into from
Jul 8, 2016
Merged

Removed execa dependency #27

merged 7 commits into from
Jul 8, 2016

Conversation

mackermans
Copy link
Collaborator

@mackermans mackermans commented Jul 5, 2016

Replaced with custom childprocess exec implementation

@davesnx
Copy link
Member

davesnx commented Jul 5, 2016

I like it brah 👍

So sad that execa didn't work with 0.10.40 and also more sad that atom uses node -v 0.10

@davesnx
Copy link
Member

davesnx commented Jul 5, 2016

Could you also, publish a patch?

PS: and we could remove the is-path dependency, it's quite trivial.
It's actually merge this checks:
https://github.com/jonschlinkert/is-invalid-path/blob/master/index.js +
https://github.com/jonschlinkert/is-glob/blob/master/index.js +
https://github.com/jonschlinkert/is-extglob/blob/master/index.js

What do you think @mackermans ?

@mackermans
Copy link
Collaborator Author

@davesnx I think we can keep it for now, it's a small dependency. I also added the strip-eof dependency so we're not zero-dependency anyway.

@davesnx
Copy link
Member

davesnx commented Jul 6, 2016

Could you update travis to add 0.10 also?

@mackermans mackermans merged commit 1732923 into master Jul 8, 2016
@mackermans mackermans deleted the Remove_execa_dependency branch July 8, 2016 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants