Update to allow developers to customize the fetching of the update #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
information, diffs and binaries
sanbornm
added a commit
that referenced
this pull request
Oct 17, 2015
Update to allow developers to customize the fetching of the update
|
Thank you so much! |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
information, diffs and binaries
The specific issue my team is hitting is occurring is io timeouts are happening in http requests. Ideally I'd like a way to be able control the http requests, perhaps to add some code to do an exponential backoff and additional requests. I was going to actually add that into this change, but decided it was best just to have a hook. People may want to do a number of things. Perhaps connect to an endpoint with a cert as another example. I added some basic tests. I can't quite add testing for everything as the osext picks the exe up. Though I though I could at least add some tests as a starting point. Further refactoring can make this easier to test.