Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spinner to indicate app loading #833

Merged
merged 2 commits into from Feb 13, 2022
Merged

Add spinner to indicate app loading #833

merged 2 commits into from Feb 13, 2022

Conversation

sumitde22
Copy link
Contributor

@sumitde22 sumitde22 commented Feb 9, 2022

Description

Application now shows a loading spinner instead of flashing the no courses page temporarily when a user logs in

Makes login look a little cleaner

Closes #828

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe how you tested this PR (both manually and with tests)
Provide instructions so we can reproduce.

  • Test A: Logged in with student account in dev and loading spinner showed before opening homepage
  • Test B: Logged in with student account with no courses in dev and loading spinner showed before showing no courses page

Screen Shot 2022-02-09 at 12 15 56 PM

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Feb 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sandboxneu/office-hours/8SWWkp3w7TkEBALXgnNDcyqLtbNu
✅ Preview: https://office-hours-git-nocoursesflash-sandboxneu.vercel.app

@sumitde22
Copy link
Contributor Author

Small note: I realized after pushing that I unnecessarily renamed the didRedirect hook and I made another commit to revert that, but it's not showing up in the PR

Copy link
Member

@ashdawngary ashdawngary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! (checked on local)

@sumitde22 sumitde22 merged commit 3532f6d into master Feb 13, 2022
@sumitde22 sumitde22 deleted the no_courses_flash branch February 13, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No courses screen flashes when logging in
3 participants