Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge master into prod (2/14/24) #253

Merged
merged 31 commits into from
Feb 22, 2024
Merged

merge master into prod (2/14/24) #253

merged 31 commits into from
Feb 22, 2024

Conversation

pranavphadke1
Copy link
Collaborator

No description provided.

Lucas-Dunker and others added 27 commits May 31, 2023 15:31
…on (#213)

* Upgrade node versions in github workflows to match project node version

* Restrict node version in package.json

* Tweak node engine version to debug vercel deployment

* Maybe matching with CCA node engine version will work?

* Limiting versions to only 14?
…0.2 (#215)

* Upgrade node versions in github workflows to match project node version

* Restrict node version in package.json

* Tweak node engine version to debug vercel deployment

* Maybe matching with CCA node engine version will work?

* Limiting versions to only 14?

* Messed around with installations and upgrades until it works)

* UPdate GitHub workflows to match version

* Upgrade Node version to 18.17.1

* Remove minor + patch version from deployment

* Remove minot + patch version from package.json

* Update tests
* Add linting rule to error on raw hex codes

* Add linting exceptions for .tsx files with SVG's

* Add and configure style-lint for erroring on non-variable hex codes

* Refactor forgotten hex codes into color variables

* Add new linting to github workflow

* Remove unused stylelint package, upgrade node version for workflows to work with stylelint

* Better specify github workflow node versions

* Fix node version typo lol

* Update postcss version in package.json

Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>

* Update lock file to match package.json

* Edit lint error message to be more detailed

* Update lockfile

* Type fix (caught because of linter, now erorrs)

* Update snapshot

---------

Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>
* Add linting rule to error on raw hex codes

* Add linting exceptions for .tsx files with SVG's

* Add and configure style-lint for erroring on non-variable hex codes

* Refactor forgotten hex codes into color variables

* Add new linting to github workflow

* Remove unused stylelint package, upgrade node version for workflows to work with stylelint

* Better specify github workflow node versions

* Fix node version typo lol

* Update postcss version in package.json

Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>

* Update lock file to match package.json

* Edit lint error message to be more detailed

* Update lockfile

* Type fix (caught because of linter, now erorrs)

* Update snapshot

* Fix linting for nested tsx files

---------

Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>
* Add dev variable in .env.development

---------

Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>
* change feedback component

* add error banner

* update snapshots

* hide error when modal toggled

* add check for only whitespace
* Revert "Update .gitignore (#220)"

This reverts commit f935a37.

* refactored zindexes on all frontend style files

* removed reverting of .gitignore
* Update styling docs to talk about Z-indexes

* Heading typo
* Side edge of section table doesn’t touch edge of parent (when logged in with #)

* fix: Frame isn’t centered on larger screen sizes (large right margin)

* fix: Navbar has different padding R to L

* fix: Corner radii is different between elements

* fix: Chevrons are uncentered with uncollapsed

Still need to discuss updating the chevron flow but this works for now

* searchbar button overlay the container's border

* standardized toggle styling

- still want to address the _NotifCheckBox styling sheet as it seems like we are moving away from it.

* Bug: Align filter bar with class cards fix

* bug: notifications sign up modal has no background transparency

* updated snapshot test

* fix linting issue

* update test
* Merge to prod 10/24/23 (#223)

* Null Filter Hotfix

* Merge master into prod (Weird rebasing) (#225)

Rebasing Fix

* Prod Merge : 11-28-23 (#233)

* Upgrade node versions in github workflows to match project node version (#213)

* Upgrade node versions in github workflows to match project node version

* Restrict node version in package.json

* Tweak node engine version to debug vercel deployment

* Maybe matching with CCA node engine version will work?

* Limiting versions to only 14?

* Upgrade Node to Version 18 + Next to Version 12, React to Version 17.0.2 (#215)

* Upgrade node versions in github workflows to match project node version

* Restrict node version in package.json

* Tweak node engine version to debug vercel deployment

* Maybe matching with CCA node engine version will work?

* Limiting versions to only 14?

* Messed around with installations and upgrades until it works)

* UPdate GitHub workflows to match version

* Upgrade Node version to 18.17.1

* Remove minor + patch version from deployment

* Remove minot + patch version from package.json

* Update tests

* Update Description for Fall 2023 Team (#214)

* Add linting rules to error on non-variable color codes  (#212)

* Add linting rule to error on raw hex codes

* Add linting exceptions for .tsx files with SVG's

* Add and configure style-lint for erroring on non-variable hex codes

* Refactor forgotten hex codes into color variables

* Add new linting to github workflow

* Remove unused stylelint package, upgrade node version for workflows to work with stylelint

* Better specify github workflow node versions

* Fix node version typo lol

* Update postcss version in package.json

Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>

* Update lock file to match package.json

* Edit lint error message to be more detailed

* Update lockfile

* Type fix (caught because of linter, now erorrs)

* Update snapshot

---------

Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>

* Filtered out NULL class results. (#216)

* Fix Roberts Name (#219)

* TSX Linting Fix - Remove tsconfig linting file from eslint config (#218)

* Add linting rule to error on raw hex codes

* Add linting exceptions for .tsx files with SVG's

* Add and configure style-lint for erroring on non-variable hex codes

* Refactor forgotten hex codes into color variables

* Add new linting to github workflow

* Remove unused stylelint package, upgrade node version for workflows to work with stylelint

* Better specify github workflow node versions

* Fix node version typo lol

* Update postcss version in package.json

Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>

* Update lock file to match package.json

* Edit lint error message to be more detailed

* Update lockfile

* Type fix (caught because of linter, now erorrs)

* Update snapshot

* Fix linting for nested tsx files

---------

Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>

* Set default dev environment variable (#217)

* Add dev variable in .env.development

---------

Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>

* Add null and undefined checking to result in filter (#222)

* Merge to prod 10/24/23 (#223) (#224)

* Null Filter Hotfix

* Update .gitignore (#220)

* Fix Missing Prereqs For (#230)

* Disallow Empty Feedback (#227)

* change feedback component

* add error banner

* update snapshots

* hide error when modal toggled

* add check for only whitespace

* Ap/refactor zindexes (#228)

* Revert "Update .gitignore (#220)"

This reverts commit f935a37.

* refactored zindexes on all frontend style files

* removed reverting of .gitignore

* Update styling docs to talk about Z-indexes (#231)

* Update styling docs to talk about Z-indexes

* Heading typo

* Pp/robert findings visual 10/4/23 bugs (#232)

* Side edge of section table doesn’t touch edge of parent (when logged in with #)

* fix: Frame isn’t centered on larger screen sizes (large right margin)

* fix: Navbar has different padding R to L

* fix: Corner radii is different between elements

* fix: Chevrons are uncentered with uncollapsed

Still need to discuss updating the chevron flow but this works for now

* searchbar button overlay the container's border

* standardized toggle styling

- still want to address the _NotifCheckBox styling sheet as it seems like we are moving away from it.

* Bug: Align filter bar with class cards fix

* bug: notifications sign up modal has no background transparency

* updated snapshot test

* fix linting issue

* update test

---------

Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>
Co-authored-by: ananyaspatil <106994008+ananyaspatil@users.noreply.github.com>
Co-authored-by: Jason Cheung <59743969+Jason0429@users.noreply.github.com>
Co-authored-by: Luke Taylor <luke@bigring.org>
Co-authored-by: Sebastian Wittrock <79394243+sebwittr@users.noreply.github.com>
Co-authored-by: Pranav Phadke <91645231+pranavphadke1@users.noreply.github.com>

---------

Co-authored-by: Lucas Dunker <dunker.l@northeastern.edu>
Co-authored-by: Zachar Hankewycz <hankewyczz@gmail.com>
Co-authored-by: ananyaspatil <106994008+ananyaspatil@users.noreply.github.com>
Co-authored-by: Jason Cheung <59743969+Jason0429@users.noreply.github.com>
Co-authored-by: Luke Taylor <luke@bigring.org>
Co-authored-by: Pranav Phadke <91645231+pranavphadke1@users.noreply.github.com>
* Update _Home.scss

* Update _Home.scss
* Update readme.md Spring 2024
* make applied filters stack on desktop; change mobile/desktop behavior cutoff

* fix vscode dumb formatting
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
searchneu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 7:19am

* initial changes and create new subscriptions page

* added subscriptions to page

* displayed section and course info

* added WIP header + linting

* current changes

* implement feedback

* fix linting issues

* Cleaned up existing code

* added View all subscriptions button logic

Currently commented out, uncomment once subscription page is finalized

* fixed typo

* Updated GQL query to give more course information

* export section formatting function

Also noticed an error on line 39 that only happens on subscription page. Might be fixed now but leaving that comment incase it's still broken

* Rewrote logic for finding sections

We now use the section ids and course ids in userInfo to find all courses that a user has subscribed to (whether directly to the course for new section alerts or to associated sections for seat opening alerts)

* Updated class card and useUserInfo hook

* Don't need to cloneDeep here

* Update ClassCard.tsx

* Update ResultsLoader.tsx

* revert generated graphql file

* Update graphql.ts

* PR comments

* memoize meetings component

---------

Co-authored-by: Ally Chao <73146562+allychao@users.noreply.github.com>
Co-authored-by: Sebastian Wittrock <sebastianwittrock927@gmail.com>
Co-authored-by: Sebastian Wittrock <sebastianwittrock@sebpro.local>
* initial changes and create new subscriptions page

* added subscriptions to page

* displayed section and course info

* added WIP header + linting

* current changes

* implement feedback

* fix linting issues

* Cleaned up existing code

* added View all subscriptions button logic

Currently commented out, uncomment once subscription page is finalized

* fixed typo

* Updated GQL query to give more course information

* export section formatting function

Also noticed an error on line 39 that only happens on subscription page. Might be fixed now but leaving that comment incase it's still broken

* Rewrote logic for finding sections

We now use the section ids and course ids in userInfo to find all courses that a user has subscribed to (whether directly to the course for new section alerts or to associated sections for seat opening alerts)

* Updated class card and useUserInfo hook

* Don't need to cloneDeep here

* Update ClassCard.tsx

* Update ResultsLoader.tsx

* revert generated graphql file

* Update graphql.ts

* Add toggle to collapse class sections

* Align dropdown icon

* Include entire table in toggle

* updated styling

* Update useState and styling names

* prevent Rerenders with DOM mounts

---------

Co-authored-by: Ally Chao <73146562+allychao@users.noreply.github.com>
Co-authored-by: Sebastian Wittrock <sebastianwittrock927@gmail.com>
Co-authored-by: Sebastian Wittrock <sebastianwittrock@sebpro.local>
Co-authored-by: Pranav Phadke <pranavmphadke@gmail.com>
* update course id slider

remove apply button, changes apply on slider release

* Update snapshot test for range filter

remove the click to the apply button

* Update tests for range filter
@sebwittr sebwittr merged commit 45f0c9e into prod Feb 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants