Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black magic probe issue #183 #196

Merged
merged 7 commits into from
Nov 21, 2017
Merged

Black magic probe issue #183 #196

merged 7 commits into from
Nov 21, 2017

Conversation

micooke
Copy link
Contributor

@micooke micooke commented Sep 29, 2017

In support of 'issue' #183 - Add Black Magic Probe (BMP) upload method …
This is basically a merge of work done by @rogerclarkmelbourne in arduino-nRF5-customised, with the addition of bootloader uploading as per @sandeepmistry openocd reference in platform.txt
Note: This incorporates changes based off feedback from @sandeepmistry, @dmikhalsky, @dlabun

  • README.md - BMP driver installation details
  • platform.txt - BMP tool setup
  • programmers.txt - Add BMP as a programmer option

micooke and others added 4 commits September 29, 2017 14:01
@micooke
In support of 'issue' sandeepmistry#183 - Add Black Magic Probe (BMP)…
b67a1e6 
… upload method

This is basically a merge of work done by @rogerclarkmelbourne in arduino-nRF5-customised, with the addition of bootloader uploading as per @sandeepmistry openocd reference in platform.txt
Note: This incorporates changes based off feedback from @sandeepmistry, @dmikhalsky, @dlabun
* README.md - BMP driver installation details
* platform.txt - BMP tool setup
* programmers.txt - Add BMP as a programmer option
@micooke
In support of 'issue' sandeepmistry#183 - Add Black Magic Probe (BMP)…
54de358 
… upload method

This is basically a merge of work done by @rogerclarkmelbourne in arduino-nRF5-customised, with the addition of bootloader uploading as per @sandeepmistry openocd reference in platform.txt
Note: This incorporates changes based off feedback from @sandeepmistry, @dmikhalsky, @dlabun
* README.md - BMP driver installation details
* platform.txt - BMP tool setup
* programmers.txt - Add BMP as a programmer option
@micooke
Update programmers.txt
91c7335 
Remove accidental references to sandeepmistry:openocd for openocd methods
@micooke
Update programmers.txt
6b4a63c
@micooke
Copy link
Contributor Author

micooke commented Sep 29, 2017

Tidy-up of #186

sandeepmistry
sandeepmistry requested changes Oct 2, 2017
View reviewed changes
Copy link
Owner

@sandeepmistry sandeepmistry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micooke thanks for splitting the PR, made a few minor comments here.

programmers.txt Outdated
@@ -18,3 +18,11 @@ cmsisdap.protocol=cmsis-dap
cmsisdap.program.protocol=cmsis-dap
cmsisdap.program.tool=openocd
cmsisdap.program.setup_command=;

bmp.name=Black Magic Probe (GDB)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change bmp to blackmagicprobe in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

platform.txt
#
# blackmagic probe upload
#
tools.blackmagicprobe.path={runtime.tools.gcc-arm-none-eabi-5_2-2015q4.path}/bin/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace the {runtime.tools.gcc-arm-none-eabi-5_2-2015q4.path}/bin/ with {compiler.path} here?

That way if gcc is upgraded, only one line needs to be updated:

compiler.path={runtime.tools.gcc-arm-none-eabi-5_2-2015q4.path}/bin/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately it looks like {compiler.path} is not visible to tools, only to the compiler itself and recipes.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed.

@sandeepmistry
Copy link
Owner

I'm going to merge this for now.

If I try to upload on a non-existent serial port on my Mac, the tool reports an error, but IDE reports Done uploading.. @micooke it would be nice to fix this ...

/Users/smistry/Library/Arduino15/packages/sandeepmistry/tools/gcc-arm-none-eabi/5_2-2015q4/bin/arm-none-eabi-gdb -quiet -cd /var/folders/5d/pmvtw7p579n5npm6p421qf540000gn/T/arduino_build_708668 -b 230400 -l 10 -ex set debug remote 0 -ex set target-async off -ex set remotetimeout 10 -ex set mem inaccessible-by-default off -ex set confirm off -ex set height 0 -ex target extended-remote \\.\/dev/cu.Bluetooth-Incoming-Port -ex monitor swdp_scan -ex attach 1 -ex file Blink.ino.elf -ex load -ex tbreak main -ex run -ex echo \nProgram complete!\n -ex quit 
\\.\/dev/cu.Bluetooth-Incoming-Port: No such file or directory.
"monitor" command not supported by this target.
Don't know how to attach.  Try "help target".
You can't do that when your target is `exec'
Don't know how to run.  Try "help target".
Reading symbols from Blink.ino.elf...done.
Temporary breakpoint 1 at 0x422: file /Users/smistry/Documents/Arduino/hardware/sandeepmistry/nRF5/cores/nRF5/main.cpp, line 29.

Program complete!

@sandeepmistry sandeepmistry merged commit d91502d into sandeepmistry:master Nov 21, 2017
@sandeepmistry sandeepmistry mentioned this pull request Nov 21, 2017
Closed
@probonopd probonopd mentioned this pull request Feb 16, 2018
Closed
@micooke
Copy link
Contributor Author

micooke commented Feb 21, 2018

@sandeepmistry - sorry i didnt see this comment until @probonopd pointed this out.
Unfortunately i couldn't figure out how to conditionally write a Program success/failed (that was portable) - so i stuck with a 'Program complete' message.

@micooke micooke deleted the BlackMagicProbe_issue183 branch February 21, 2018 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeepmistry sandeepmistry sandeepmistry requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micooke @sandeepmistry