Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-hid dependency update 0.5.x => 0.7.x #15

Merged
merged 1 commit into from May 27, 2018
Merged

node-hid dependency update 0.5.x => 0.7.x #15

merged 1 commit into from May 27, 2018

Conversation

foxxyz
Copy link
Contributor

@foxxyz foxxyz commented May 10, 2018

Current node-hid dependency version (0.5.x) throws the following errors on Node 10 / OSX during pre-install:

 LIBTOOL-STATIC Release/hidapi.a
  CXX(target) Release/obj.target/HID/src/HID.o
../src/HID.cc:207:45: error: no matching member function for call to 'NewInstance'
    Local<Object> buf = nodeBufConstructor->NewInstance(1, nodeBufferArgs);
                        ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~

Updated to latest version fixes this.

@foxxyz foxxyz mentioned this pull request May 10, 2018
@sandeepmistry sandeepmistry merged commit 6aa6145 into sandeepmistry:master May 27, 2018
@foxxyz
Copy link
Contributor Author

foxxyz commented May 28, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants