Support es6 syntax features part 1 #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 6, 2022 12:50
This is an effort towards making this a Typescript library * added Babel.js in the process (merged with browserify) * preserved the compilation process * replaced legacy JSHint with JSLint * ensured that tests passes in QUnit * extracted error reporting functions into a separate error.js file * converted files into ESModules (the compilation target is still UMD though) * preserved the way that sax is included in "imsc.all.*" build and excluded from "imsc.*" builds -- Todos: * extract IMSC objects classes into separate file * move to the Typescript compiler (google-closure-compiler can still be used for minification) * extract proper TS interfaces * export types and extract to *.d.ts definition file * fix potentially buggy code (replacing string with object in array, etc.) * use ValueObject pattern (immutable IMSC classes with parameter injection via constructor, instead of "initFromNode") * cloning process improvement
* based on: feature/transpile-babel-to-umd * modules remodelled in order to improve readability * ES6 classes used for TTML doc elements (node-types directory) * removed "vars", replaced with "const" and "let" * moved "./names.js" to "./doc-parser/namespaces.js" * fixed JSDoc comments (they were not JSDoc, because of spaces and asterisks missing) * reordered variable declarations wherever linter pointed out the issue
|
Please check this @palemieux @nigelmegitt |
BasBastian
changed the title
|
Replaced by #255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next part of changes
Please check #228 first and then advise. Contains the same set of (possibly) breaking changes