Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support es6 syntax features part 1 #229

Closed
wants to merge 2 commits into from
Closed

Support es6 syntax features part 1 #229

wants to merge 2 commits into from

Commits on Mar 6, 2022

  1. Modern ES2015+ syntax and ESModules 

    This is an effort towards making this a Typescript library
* added Babel.js in the process (merged with browserify)
* preserved the compilation process
* replaced legacy JSHint with JSLint
* ensured that tests passes in QUnit
* extracted error reporting functions into a separate error.js file
* converted files into ESModules (the compilation target is still UMD though)
* preserved the way that sax is included in "imsc.all.*" build and excluded from "imsc.*" builds

--

Todos:
* extract IMSC objects classes into separate file
* move to the Typescript compiler (google-closure-compiler can still be used for minification)
* extract proper TS interfaces
* export types and extract to *.d.ts definition file
* fix potentially buggy code (replacing string with object in array, etc.)
* use ValueObject pattern (immutable IMSC classes with parameter injection via constructor, instead of "initFromNode")
* cloning process improvement
    BasBastian committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    22d7d2d View commit details
    Browse the repository at this point in the history

  2. Modern ES6+ syntax of modules 

    * based on: feature/transpile-babel-to-umd
* modules remodelled in order to improve readability
* ES6 classes used for TTML doc elements (node-types directory)
* removed "vars", replaced with "const" and "let"
* moved "./names.js" to "./doc-parser/namespaces.js"
* fixed JSDoc comments (they were not JSDoc, because of spaces and asterisks missing)
* reordered variable declarations wherever linter pointed out the issue
    BasBastian committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    9db7ad4 View commit details
    Browse the repository at this point in the history