Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 #4

Merged
merged 2 commits into from
Jan 20, 2019
Merged

V2 #4

merged 2 commits into from
Jan 20, 2019

Conversation

sandfox
Copy link
Owner

@sandfox sandfox commented Jan 20, 2019

New api - rewritten internals!

James Edward Butler added 2 commits January 20, 2019 17:24
update license copyright
cdee464
rewrite to use newer api
04ab0e8 
remove test dependencies
remove old implementation
change npm namespace
@sandfox sandfox merged commit d1c901d into master Jan 20, 2019
@defel
Copy link

defel commented Mar 20, 2019

can you npm publish this? 💪 :)

@sandfox
Copy link
Owner Author

sandfox commented Mar 20, 2019

@defel it's here -> https://www.npmjs.com/package/@sandfox/arn

@sandfox
Copy link
Owner Author

sandfox commented Mar 20, 2019

I should probably add a link/deprecation notice to the v1 package!

@defel
Copy link

defel commented Mar 20, 2019

I see, thank you!
Maybe you can deprecate the old package? ( https://www.npmjs.com/package/aws-arn-parser )

https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions

@sandfox sandfox mentioned this pull request Mar 20, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sandfox @defel