Improve QEMU integration #1070
Merged
Improve QEMU integration #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `vm config machine` and `vm config cpu` based on output from the current `vm config qemu`. Make network drivers dependent on `vm config qemu` and `vm config machine`. Add `validate` and `suggest` to vmconfiger so that we can check the values for `vm config`s and suggest their values. Fixes sandia-minimega#910, sandia-minimega#911, sandia-minimega#1016.
For qemu-arm which is different than qemu-x86/amd64.
Need to include machine name in "name". Update example with actual output.
Try to resolve non-absolute qemu path using $PATH.
Used wrong index for CPU fields.
Looks like I did not add it earlier like I thought that I had.
|
:O :) |
|
Not sure the network driver detection is correct. See note here. |
Split the qemu capabilities code out into its own package. Add tests based on predefined output. Change NIC code so that it pulls from `-device` rather than `-nic` since we use `-device` when creating NICs in minimega.
Using old (wrong) command.
Adds new fields and new default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Don't merge, yet.
Add
vm config machineandvm config cpubased on output from the currentvm config qemu. Make network drivers dependent onvm config qemuandvm config machine. Addvalidateandsuggestto vmconfiger so that we can check the values forvm configs and suggest their values.Also adds
vm config cores.Fixes #910, #911, and #1016.
@mkunz7