Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve QEMU integration #1070

Merged
merged 11 commits into from Jun 4, 2018

Conversation

Projects
None yet
3 participants
@jcrussell
Copy link
Contributor

jcrussell commented Feb 20, 2018

WIP: Don't merge, yet.

Add vm config machine and vm config cpu based on output from the current vm config qemu. Make network drivers dependent on vm config qemu and vm config machine. Add validate and suggest to vmconfiger so that we can check the values for vm configs and suggest their values.

Also adds vm config cores.

Fixes #910, #911, and #1016.

@mkunz7

jcrussell added some commits Nov 7, 2017

minimega,vmconfiger: smarter qemu checks
Add `vm config machine` and `vm config cpu` based on output from the
current `vm config qemu`. Make network drivers dependent on `vm config
qemu` and `vm config machine`. Add `validate` and `suggest` to
vmconfiger so that we can check the values for `vm config`s and suggest
their values.

Fixes #910, #911, #1016.
minimega: improve QEMU CPU detection
For qemu-arm which is different than qemu-x86/amd64.
minimega: fix bug with QEMU CPU detect
Need to include machine name in "name". Update example with actual
output.
minimega: fix relative path to qemu
Try to resolve non-absolute qemu path using $PATH.
minimega: fix wrong index
Used wrong index for CPU fields.
minimega: add `vm config cores`
Looks like I did not add it earlier like I thought that I had.

@jcrussell jcrussell added this to the 2.5 milestone Feb 20, 2018

@mkunz7

This comment has been minimized.

Copy link
Contributor

mkunz7 commented Feb 20, 2018

:O :)

@jcrussell

This comment has been minimized.

Copy link
Contributor Author

jcrussell commented Mar 28, 2018

Not sure the network driver detection is correct. kvm -net nic,model=? returns a different list than kvm -device driver=?. We should probably use the latter.

See note here.

jcrussell added some commits Apr 16, 2018

minimega/qemu: split, change NIC code
Split the qemu capabilities code out into its own package. Add tests
based on predefined output. Change NIC code so that it pulls from
`-device` rather than `-nic` since we use `-device` when creating NICs
in minimega.
qemu: fix bug with NICs
Using old (wrong) command.
tests: update vm_config_save
Adds new fields and new default.
@djfritz

djfritz approved these changes Jun 4, 2018

Copy link
Contributor

djfritz left a comment

LGTM

@djfritz djfritz merged commit 51647ba into sandia-minimega:master Jun 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jcrussell jcrussell deleted the jcrussell:issue-910-911-1016 branch Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.