Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: vm config cores #911

Closed
mkunz7 opened this issue May 3, 2017 · 1 comment
Closed

Feature request: vm config cores #911

mkunz7 opened this issue May 3, 2017 · 1 comment
Assignees
@jcrussell
Milestone
2.5

Comments

@mkunz7
Copy link
Contributor

mkunz7 commented May 3, 2017 •
edited
Loading 

vm config vcpus

changes the number of processors, but not the number of cores

vm config vcpus 4
vm config cores 2

should generate the qemu string

-smp 4,cores=2

which should give 8 total cores on 4 processors
@mkunz7 mkunz7 changed the title Feature request: vm config smp Feature request: vm config cores May 3, 2017
@jcrussell
Copy link
Contributor

This is easy to add. @djfritz: is it worth supporting?

@djfritz djfritz added this to the 2.5 milestone Sep 21, 2017
jcrussell added a commit to jcrussell/minimega that referenced this issue Nov 7, 2017
@jcrussell
minimega,vmconfiger: smarter qemu checks
03bbf49 
Add `vm config machine` and `vm config cpu` based on output from the
current `vm config qemu`. Make network drivers dependent on `vm config
qemu` and `vm config machine`. Add `validate` and `suggest` to
vmconfiger so that we can check the values for `vm config`s and suggest
their values.

Fixes sandia-minimega#910, sandia-minimega#911, sandia-minimega#1016.
@jcrussell jcrussell mentioned this issue Feb 20, 2018
Merged
@jcrussell jcrussell self-assigned this May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcrussell jcrussell

Labels
None yet
Projects
None yet
Milestone
2.5
Development

No branches or pull requests
3 participants
@jcrussell @djfritz @mkunz7