Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Epetra #1028

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Remove Epetra #1028

merged 5 commits into from
Mar 8, 2024

Conversation

mperego
Copy link
Collaborator

@mperego mperego commented Mar 7, 2024

This PR removes all the code related to Epetra and all the tests associated to Epetra.
Before the removal, the Epetra tests that did not have a Tpetra analog have been converted to Tpetra tests.

The build_type has been removed, so "Build Type" needs to be removed from input yaml files.

…coverage

Also pruned some unused files and improve the solver sections of tests,
adding solver settings and verbosity options
Removed all parts of the code related to Epetra.
Also removed Build_Type
Copy link
Collaborator

@bartgol bartgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think there's one FO_GIS test that is redundant, but other than that it's good.

Perhaps at a later stage, we could rename all the blahT.yaml file to blah.yaml (or viceversa). There's a bit of a mix right now, due to leftover from epetra-vs-tpetra duplication of some tests...

@mcarlson801
Copy link
Collaborator

It looks like some of the tests are failing with this branch on weaver:

 46 - landIce_FO_GIS_Unstructured_Restart (Failed)
 61 - landIce_FO_GIS_SensSMBwrtBeta_Restart (Failed)
 64 - landIce_FO_GIS_Humboldt_LaplacianPriorSampling (Failed)
 99 - corePDEs_SideSetLaplacian_3D (Failed)

The FO_GIS tests are failing to find decomposed meshes:

Exodus Library Warning/Error: [ex__check_file_type]
    ERROR: Could not open file '/home/maxcarl/weaver/builds/albany-remove_epetra/tests/landIce/FO_GIS/gis_unstruct.exo.4.3', error = No such file or directory.

I think this is something Luca just fixed for other tests. Do we need to add something to the inputs for these tests?

The SideSetLaplacian_3D test is failing with the following error:

99: ************************************************************************
99: -- Nonlinear Solver Step 49 --
99: ||F|| = 2.500e-01  step = 1.000e+00  dx = 0.000e+00
99: ************************************************************************
99:
99: Ifpack2::ILUT::Compute: zero pivot encountered! Replacing with rownorm and continuing...(You may need to set the parameter 'fact: absolute threshold'.)
99: Ifpack2::ILUT::Compute: zero pivot encountered! Replacing with rownorm and continuing...(You may need to set the parameter 'fact: absolute threshold'.)
99: Ifpack2::ILUT::Compute: zero pivot encountered! Replacing with rownorm and continuing...(You may need to set the parameter 'fact: absolute threshold'.)
99: Ifpack2::ILUT::Compute: zero pivot encountered! Replacing with rownorm and continuing...(You may need to set the parameter 'fact: absolute threshold'.)
99:
99:   *******************************************************
99:   ***** Belos Iterative Solver:  Block Gmres
99:   ***** Maximum Iterations: 100
99:   ***** Block Size: 1
99:   ***** Residual Test:
99:   *****   Test 1 : Belos::StatusTestImpResNorm<>: (2-Norm Res Vec) / (2-Norm Res0), tol = 0.0001
99:   *******************************************************
99:   Iter   0, [ 1] :    1.000000e+00
99:   Belos::BlockGmresSolMgr::solve(): Warning! NaN has been detected!
99: WARNING: NOX::Direction::Newton::compute() - Linear solve failed to achieve convergence - using the step anyway since "Rescue Bad Newton Solve" is true
99: NOX::Solver::LineSearchBased::iterate - using recovery step for line search

Not sure why this would fail but not the 2D version.

@mperego
Copy link
Collaborator Author

mperego commented Mar 7, 2024

It looks like some of the tests are failing with this branch on weaver:

 46 - landIce_FO_GIS_Unstructured_Restart (Failed)
 61 - landIce_FO_GIS_SensSMBwrtBeta_Restart (Failed)
 64 - landIce_FO_GIS_Humboldt_LaplacianPriorSampling (Failed)
 99 - corePDEs_SideSetLaplacian_3D (Failed)

The FO_GIS tests are failing to find decomposed meshes:

Exodus Library Warning/Error: [ex__check_file_type]
    ERROR: Could not open file '/home/maxcarl/weaver/builds/albany-remove_epetra/tests/landIce/FO_GIS/gis_unstruct.exo.4.3', error = No such file or directory.

I think this is something Luca just fixed for other tests. Do we need to add something to the inputs for these tests?

The SideSetLaplacian_3D test is failing with the following error:

99: ************************************************************************
99: -- Nonlinear Solver Step 49 --
99: ||F|| = 2.500e-01  step = 1.000e+00  dx = 0.000e+00
99: ************************************************************************
99:
99: Ifpack2::ILUT::Compute: zero pivot encountered! Replacing with rownorm and continuing...(You may need to set the parameter 'fact: absolute threshold'.)
99: Ifpack2::ILUT::Compute: zero pivot encountered! Replacing with rownorm and continuing...(You may need to set the parameter 'fact: absolute threshold'.)
99: Ifpack2::ILUT::Compute: zero pivot encountered! Replacing with rownorm and continuing...(You may need to set the parameter 'fact: absolute threshold'.)
99: Ifpack2::ILUT::Compute: zero pivot encountered! Replacing with rownorm and continuing...(You may need to set the parameter 'fact: absolute threshold'.)
99:
99:   *******************************************************
99:   ***** Belos Iterative Solver:  Block Gmres
99:   ***** Maximum Iterations: 100
99:   ***** Block Size: 1
99:   ***** Residual Test:
99:   *****   Test 1 : Belos::StatusTestImpResNorm<>: (2-Norm Res Vec) / (2-Norm Res0), tol = 0.0001
99:   *******************************************************
99:   Iter   0, [ 1] :    1.000000e+00
99:   Belos::BlockGmresSolMgr::solve(): Warning! NaN has been detected!
99: WARNING: NOX::Direction::Newton::compute() - Linear solve failed to achieve convergence - using the step anyway since "Rescue Bad Newton Solve" is true
99: NOX::Solver::LineSearchBased::iterate - using recovery step for line search

Not sure why this would fail but not the 2D version.

I'll fix the tests failing for the error with loading the mesh.
As for the SideSetLaplacian_3D test, it must be some uninitialized variable or something like that. On my workstation it converges in 1 iteration. I'll see if I can find the culprit, but I might go ahead and push the PR anyway, and address the error later.

@mperego
Copy link
Collaborator Author

mperego commented Mar 8, 2024

OK, I have renamed the tests to remove references to Tpetra and hopefully fixed the exudus issues in the test files.
I could not reproduce the issue with SideSetLaplacian_3D on weaver. But I'd rather push the PR and we look at that later.

Copy link
Collaborator

@bartgol bartgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great cleanup work Mauro! I love PRs with more red than green... :)

Copy link
Collaborator

@mcarlson801 mcarlson801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mperego
Copy link
Collaborator Author

mperego commented Mar 8, 2024

Thanks @bartgol and @mcarlson801 for your feedback!

@mperego mperego merged commit a7d77a0 into master Mar 8, 2024
@mperego mperego deleted the mperego/remove_epetra branch March 8, 2024 16:48
mperego added a commit to MALI-Dev/E3SM that referenced this pull request Mar 8, 2024
Epetra solver stack is no longer available, and this change will be needed with newer versions of Albany.
See sandialabs/Albany#1028
mperego added a commit to sandialabs/ali-perf-tests that referenced this pull request Mar 8, 2024
trhille added a commit to MALI-Dev/E3SM that referenced this pull request Mar 27, 2024
Remove "Build Type" option from albany input file. Epetra solver
stack is no longer available through Albany and this change will
be needed with newer versions of Albany.
See sandialabs/Albany#1028
This will work with older versions of Albnay if Albany is built
with no Epetra support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants