-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Epetra #1028
Remove Epetra #1028
Conversation
…coverage Also pruned some unused files and improve the solver sections of tests, adding solver settings and verbosity options
Removed all parts of the code related to Epetra. Also removed Build_Type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I think there's one FO_GIS test that is redundant, but other than that it's good.
Perhaps at a later stage, we could rename all the blahT.yaml file to blah.yaml (or viceversa). There's a bit of a mix right now, due to leftover from epetra-vs-tpetra duplication of some tests...
It looks like some of the tests are failing with this branch on weaver:
The FO_GIS tests are failing to find decomposed meshes:
I think this is something Luca just fixed for other tests. Do we need to add something to the inputs for these tests? The SideSetLaplacian_3D test is failing with the following error:
Not sure why this would fail but not the 2D version. |
I'll fix the tests failing for the error with loading the mesh. |
ad69bd2
to
e41062c
Compare
OK, I have renamed the tests to remove references to Tpetra and hopefully fixed the exudus issues in the test files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great cleanup work Mauro! I love PRs with more red than green... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks @bartgol and @mcarlson801 for your feedback! |
Epetra solver stack is no longer available, and this change will be needed with newer versions of Albany. See sandialabs/Albany#1028
Remove "Build Type" option from albany input file. Epetra solver stack is no longer available through Albany and this change will be needed with newer versions of Albany. See sandialabs/Albany#1028 This will work with older versions of Albnay if Albany is built with no Epetra support.
This PR removes all the code related to Epetra and all the tests associated to Epetra.
Before the removal, the Epetra tests that did not have a Tpetra analog have been converted to Tpetra tests.
The build_type has been removed, so "Build Type" needs to be removed from input yaml files.