Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate all tagged functors in GMLS class into separate structs/functors #257

Merged
merged 59 commits into from
Nov 1, 2021
Merged

Separate all tagged functors in GMLS class into separate structs/functors #257

merged 59 commits into from
Nov 1, 2021

Conversation

kuberry
Copy link
Collaborator

@kuberry kuberry commented Oct 21, 2021

No description provided.

@kuberry
Test to separate functors from GMLS class
cd55ef2
@kuberry
Converted assemble and apply for standard problems to separate functors
b7fc5c6
@kuberry
Converted ComputePrestencilWeights to separate struct
d8e5b5d
@kuberry
Added struct for holding functor data and added TeamPolicy creator
e7526d8
@kuberry
Created GMLSBasisData struct with all GMLS member variables
2bf9c5a 
Switched ComputePrestencil functor to use this struct for non-member
function calls to GMLS
@kuberry
Add PointConnections class
b178a8c
@kuberry
Converted GMLS class to using PointConnections
690e51c
@kuberry
Converted additional evaluation sites over to using PointConnections
ec38b2b
@kuberry
Merge branch 'point_connectivity' into separate_functors
e3ebf35
@kuberry
Comment out print statement
bb4b527
@kuberry
Moved Basis operations out of GMLS class
9a9bab8 
- Removed getNNeighbors and getMaxNNeighbors from GMLS class, now
  everything uses neighbor lists directly to get this information
- Changed Compadre_GMLS_Basis.hpp to Compadre_Basis.hpp, as its
  assembly routines are more general than GMLS
- Modified all other parts of GMLS calls to Basis functionality to
  agree with functions external to the GMLS class
@kuberry
Moved Target operations out of GMLS class
85b3376
@kuberry
Changed captures from = to &
d6b74fb
@kuberry
Change more captures from = to &
3fda27f
@kuberry
Switched ComputePrestencilWeights and AssembleStandardPsqrtW to only …
c6c2a2d 
…using GMLSBasisData
@kuberry
Continue switching from _gmls to _data in ApplyStandardTargets
d55affc
@kuberry
Extracted all _alpha values and functionality to SolutionSet class
659841d
@kuberry
Added missing _h_ss setting of neighbor lists
6d3ce26
@kuberry
Add updates to _h_ss for _max_evaluation_sites_per_target
31c8f3c
@kuberry
Fixed incorrect data sampling functional being used in dimension calc…
6fee485 
…ulation
@kuberry
Change return type of SolutionSet from GMLS, resize _lro* vectors on …
23edee1 
…copy
@kuberry
Three main functors all converted to using GMLSBasisData
0cb0576
@kuberry
Make getSolutionSetHost() check _alpha size and selectively perform copy
424ac27
@kuberry
Replaced with Z
4aac81b
@kuberry
Separated ApplyStandardTargets into EvaluateStandardTarget and ApplyS…
2d4e8a4 
…tandardTargets
@kuberry
Returned variables in GMLS class back to private
8afba3b 
- Private variables needing copied are handled by their data
  struct being friended to the GMLS class
@kuberry
Converted all remaining manifold tags to functors
34bb7d7
@kuberry
Moved functor data generation to inside of batch loop
e84a979
@kuberry
Make point_connections_type typedef in GMLS class public
50690b1 
- Also reorganized GMLSBasisData struct members
@kuberry
Changed KOKKOS_LAMBDA to [&] for private members in GMLS
d2f408e
@kuberry
Copy link
Collaborator Author

kuberry commented Oct 21, 2021

Addresses issue #253

@kuberry
Copy link
Collaborator Author

kuberry commented Oct 21, 2021

Removes G_inv #255

kuberry and others added 17 commits October 21, 2021 16:54
@kuberry
Changed getSolutionSetHost to _h_ss in Evaluator
c4f4d6c
@kuberry
Change reference type for getSolutionSet in pycompadre and fixed _lro…
fcb9d17 
…_lookup
@kuberry
Embedded ActualReconstructionSpaceRank in getActualReconstructionSpac…
e019451 
…eRank

- Did the same for TargetOutputTensorRank
- Reason for change is that 11.3 of cuda doesn't recognize constexpr
  int array is accessible from device
@kuberry
Make Kokkos_CXX_STANDARD consistent with Compadre's
954f4e5
@kuberry
Improved template for indexing in SolutionSet
da91121 
- Removed GMLS destructor (not needed)
@kuberry
Moved all functor definitions to Compadre_Functors.hpp
6817dec
@kuberry
Made some reused variables const
58b8d2c
@kuberry
Removed PerThread in ApplyTargets
423e8e7
@kuberry
Rearranged parallel_for location for GPU ApplyTargets
bc9c586
@kuberry
Switch back to CMAKE_CXX_STD 11, even for GPU (consistent with Kokkos…
3b68c7e 
… version included)
@kuberry
GPU thread level defaults to 0 instead of 1 now
ffd3052
@kuberry
Initialized a previously uninitialized value
4eef7a0
@kuberry
Replace TeamThreadRange with for loop for thread scratch memory
87a4b6b
@kuberry
Replace another TeamThreadRange with for loop and add kernel to assert
0573b60
@kuberry
Initialize alphas to zero
444291c 
- If not set to zero, possible to be read in and used by Evaluator
  uninitialized (NaNs)
@kuberry
Change some const ints to nonconst because of gcc 7.2 issue
e3f315a
@kuberry
Refactored std::vector in SolutionSet
7a95fd6
This was referenced Oct 31, 2021
Open
Closed
@kuberry
Bump Compadre Toolkit to version 1.4.0
be83ae3 
- All functors extracted from GMLS class
- Add SolutionSet struct
- Add PointConnections struct
@kuberry kuberry added TOOLKIT enhancement New feature or request labels Nov 1, 2021
@kuberry kuberry merged commit 5dbbbe3 into master Nov 1, 2021
@kuberry kuberry deleted the separate_functors branch November 9, 2021 23:24
@kuberry kuberry mentioned this pull request Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request TOOLKIT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kuberry