Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Python 2 support #90

Closed
8 tasks done
robpkelly opened this issue Sep 13, 2019 · 3 comments
Closed
8 tasks done

Dropping Python 2 support #90

robpkelly opened this issue Sep 13, 2019 · 3 comments
Labels
discussion Request for further conversation to figure out action steps inactive Progress on this issue is temporarily on hold low priority Developers should be aware of this issue, but it need not be addressed imminently

Comments

@robpkelly
Copy link
Contributor

robpkelly commented Sep 13, 2019

Python 2.7 will reach end-of-life on January 1st, 2020 (see this melodramatic countdown timer). Additionally, many major Python projects have pledged to drop support for Python 2 on or before that date.

The next major release of pyGSTi (v0.9.9) will drop support for Python 2. In other words, we'll be limiting our future support to Python 3.5 and 3.7. Users running pyGSTi on Python 2 should consult the official guide for more information on porting their environment to Python 3.


As of ace6d65 our CI no longer builds for Python 2.7. Developers are no longer required to ensure Python 2.7 compatibility in new contributions. Here's what should be done before v0.9.9:

  • Drop Python 2.7 builds from TravisCI
  • Specify python_requires in setup.py
  • Remove Python 2 backports from dependencies in setup.py
    • Not sure we actually have any strictly for Python 2...
  • Remove Python 2 compatibility duct-tape throughout the source tree, including:
    • sys.version_info checks for python 2
    • most if not all __future__ imports
    • Python 2 compatibility patches in pygsti.tools.compattools
  • Remove Python 2 static test fixture resources
@robpkelly robpkelly added discussion Request for further conversation to figure out action steps inactive Progress on this issue is temporarily on hold labels Sep 13, 2019
@robpkelly robpkelly added the low priority Developers should be aware of this issue, but it need not be addressed imminently label Sep 13, 2019
@robpkelly
Copy link
Contributor Author

This is all just housekeeping, by the way, so consider this low-priority.

@LSaldyt
Copy link
Contributor

LSaldyt commented Sep 13, 2019

Finally! Best of luck :)

@robpkelly
Copy link
Contributor Author

#102 closes this, but I'm keeping this issue open until v0.9.9 just to keep users/developers aware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Request for further conversation to figure out action steps inactive Progress on this issue is temporarily on hold low priority Developers should be aware of this issue, but it need not be addressed imminently
Projects
None yet
Development

No branches or pull requests

2 participants