Refactor pygsti.baseobjs
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally cleaned up some import indirection. A few small useful constants (sqrt2, id2x2, sigmax/y/z) defined in `tools.basisconstructors` are referenced elsewhere. `basis_matrices`, `basis_longname`, and `basis_element_labels` have been refactored from `objects.basis` to `tools.basistools`. `tools.basistools` does not wildcard-import from `tools.basisconstructors`; if this is a more significant API change than I anticipate (i.e. if anyone might notice), please add deprecation warnings where appropriate.
…fast implementation
We now have `tools.opttools` in addition to `tools.optools`. Should consider an API change to one of these for usability's sake.
|
Let's restore the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're dropping Python 2.7 support with #90, it's easier to avoid circular imports, meaning we can refactor the names under the
baseobjspackage to other existing packages that make more sense.objects:baseobjs.smartcachebaseobjs.verbosityprinterbaseobjs.profilerbaseobjs.basisbaseobjs.protectedarraybaseobjs.labelbaseobjs.objectivefnstools:baseobjs.opttoolsbaseobjs.basisconstructorsio:baseobjs.circuitparserbaseobjs.fastcircuitparserbaseobjs.parameterizedbaseobjs.deprecated_dimbaseobjs.exceptionsSince names under
baseobjswere deliberately exposed in other modules, this should not constitute a major API change. One possible exception is thatbasistoolsno longer exposes thebasisconstructorsnamespace via wildcard import. If this actually is a non-trivial API change, I'd want to either re-expose those names with a deprecation warning, or simply mergebasisconstructorsintobasistoolsentirely (I'm a little confused on the semantics of separating them in the first place)