Fix gcc 4.8 5 compilation errors for IOSS used in VTK

[spyridon97]

The purpose of this PR is to fix compilations issues using gcc 4.8.5 for the IOSS package which is utilized in VTK

@mathstuf

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[gsjaardema]

Sorry, I'm not going to revert back to pre C99...

[gsjaardema]

Those look good. Thanks.

[spyridon97]

I have read the CLA Document and I hereby sign the CLA

[spyridon97]

recheck

[spyridon97]

recheck

[spyridon97]

@gsjaardema CI has passed. CI does not understand that i have read and agreed to the CLA document.

[spyridon97]

I have read the CLA Document and I hereby sign the CLA

[spyridon97]

recheck

[gsjaardema]

@spyridon97 Not sure why. I reran it manually and it worked...

[gsjaardema]

I could move Ioss_Getline.c to be a C++ file which would possibly solve the issue you are seing without reverting to pre-C99 if that works for you?

[spyridon97]

I could move Ioss_Getline.c to be a C++ file which would possibly solve the issue you are seing without reverting to pre-C99 if that works for you?

That should work for me.

Just remove it from

set(c_sources
  Ioss_Getline)

And you can remove the second commit.

[gsjaardema]

I think the c_sources is on your side. I don't see it in my code.

[gsjaardema]

I don't think I can remove that commit from the PR. I have moved Ioss_Getline.c to a C++ file. I can also just make the ParallelUtils changes outside this PR which might be the easiest way to do this...

[spyridon97]

I can also just make the ParallelUtils changes outside this PR which might be the easiest way to do this...

That sounds good!

[gsjaardema]

Commit 926571d has been comitted outside this PR. The other commit in the PR is not needed due to changing Ioss_Getline.c to be a C++ file.