Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility coloration in table wrong for rows with Nans #792

Closed
pjcross opened this issue Nov 28, 2017 · 0 comments
Closed

Visibility coloration in table wrong for rows with Nans #792

pjcross opened this issue Nov 28, 2017 · 0 comments
Assignees

Comments

@pjcross
Copy link
Contributor

pjcross commented Nov 28, 2017

image
I think that we must be using the same table coloring rules for Parameter Space as we are using for CCA, which provides the mistaken impression that any row with a Nan in a column that has been declared as either an input or an output is not visible. Unlike CCA, a row with a Nan is not automatically filtered out by virtue of the Nan in an input or an output column. That row should have the usual green/purple/white color-coding for the input/output/neither columns. Since we are using a white row to show non-visibility due to filtering, the visible row with a Nan looks much like the non-visible, filtered out rows around in the example above. Only the faded text shows the difference. There are only two cases where having a Nan in the row should make a difference to the color-coding: (1) if the column with the Nan is being used as an axis in the scatterplot, this row can not be shown due to the lack of a coordinate value (2) if the column with the Nan is one of the filters and NULL values are not enabled. It seems to me that although neither case reflects an explicit removal of these points, they are essentially non-visible points and should be colored using the same scheme as any other non-visible points (white rows with faded text). The case of white row with regular black text should not occur unless all columns are defined as 'neither'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants