Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to filter specs there are none #32

Merged
merged 1 commit into from
Feb 29, 2012
Merged

Do not try to filter specs there are none #32

merged 1 commit into from
Feb 29, 2012

Conversation

jgdavey
Copy link
Contributor

@jgdavey jgdavey commented Feb 29, 2012

This fixes a bug where running specjour features would fail because RSpec had not been loaded. The error complained about RSpec.world not being available, likely due to RSpec being lazily loaded.

This fixes a bug where running `specjour features` would fail because
RSpec had not been loaded
@sandro
Copy link
Owner

sandro commented Feb 29, 2012

Oh damn! Thanks!

@sandro
Copy link
Owner

sandro commented Feb 29, 2012

How can I convince you to write the code that gathers scenario line numbers, so we can run individual scenarios instead of files? I don't have a slow cucumber suite ATM, so I skipped it, but now that we distribute rspec examples, it only makes sense to distribute cucumber scenarios. Some of the cuke folks recommended I look into --dry-run or --expand.

sandro added a commit that referenced this pull request Feb 29, 2012
Do not try to filter specs there are none
@sandro sandro merged commit 42ee2bd into sandro:master Feb 29, 2012
@jgdavey
Copy link
Contributor Author

jgdavey commented Feb 29, 2012

Ah ha! If you give a mouse (sandro) a cookie (a small patch)...

That would be an interesting project for one of our open-source Fridays. Not committing to that yet (could be a big undertaking, after all), but definitely interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants