Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No file extension on grain backup with Firefox #34

Closed
ocdtrekkie opened this issue Jul 3, 2014 · 3 comments
Closed

No file extension on grain backup with Firefox #34

ocdtrekkie opened this issue Jul 3, 2014 · 3 comments

Comments

@ocdtrekkie
Copy link
Collaborator

Not getting the .zip file extensions on grain backups with Firefox. Got them correctly with Chrome and IE11. Tested with Windows 7.

Side note: Something like .grain might be preferable since they're not really intended to be opened by users. If you know enough to poke around in it, you probably should know enough to rename the extension yourself.

@ocdtrekkie
Copy link
Collaborator Author

Issue might be specific to the Sandstorm Alpha server.

Updated my Sandstorm instance on my Ubuntu VM. With Firefox on Ubuntu, my localhost Sandstorm downloads grains as .ZIP, Alpha server downloads them without an extension.

@kentonv
Copy link
Member

kentonv commented Jul 3, 2014

This is odd. We are sending .zip in the filename header, and the code is identical on the alpha server and locally, but I am observing the same behavior you are. I also notice that Firefox doesn't like when the filename contains a space, but that seems to be a separate issue.

It's going to be pretty annoying trying to debug something that only happens in prod... :/

kentonv added a commit that referenced this issue Jul 3, 2014
… This makes things work better on Firefox. Unknown at this point whether this will fix the issue in production where the .zip extension gets lost (issue #34).
@kentonv
Copy link
Member

kentonv commented Jul 3, 2014

It appears that the change fixed the bug. I'm not sure if it was the addition of quotes or setting the correct MIME type that did it, but either way Firefox is now adding ".zip" when downloading from the alpha server.

@kentonv kentonv closed this as completed Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants