Fix Vagrantfile's Windows RAM calculation #3206
Conversation
See sandstorm-io/vagrant-spk#241 for the same fix on vagrant-spk, see sandstorm-io/vagrant-spk#240 for details on how the existing command responds (listing half the RAM twice instead of providing a single valid amount of RAM). But in short, the PowerShell command
|
As an aside (since I'd want to do it in vagrant-spk too/first)... I am really tempted to remove the rescue block. What on earth are we doing with code designed to prevent failure on XP and Vista? |
|
I'm fine with junking the rescue, given that both of those OSes are EOL. |
|
I'll test removing it and then add that change here and to vagrant-spk. There are still people adamantly using Windows 7, but I know of nobody militantly attached to Windows Vista. Furthermore, as I noted in the vagrant-spk repo, I believe this bug should error out because the PowerShell is wrong, but the rescue block likely was suppressing the fact that this code was broken. |
|
Tested vagrant-spk with the original broken version which gave me a 512 MB RAM VM (the default), and with the corrected command and the rescue block removed, and got a 4 GB RAM VM (a quarter of my system RAM). |
Effectively drops support for Windows XP/Vista from Vagrant installs of Sandstorm, but fixes an issue where broken code here does not error out and simply fails silently.
|
I have no idea what this does but I trust you. :) |
See sandstorm-io/vagrant-spk#241 for the same fix on vagrant-spk, see sandstorm-io/vagrant-spk#240 for details on how the existing command responds (listing half the RAM twice instead of providing a single valid amount of RAM).