Convert adapter view package to Kotlin #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis CI doesn't create Javadoc when compiling Kotlin Therefore, add the gradle configuration to skip Javadoc to avoid this issue.
sangcomz
reviewed
Oct 3, 2019
FishBun/src/main/java/com/sangcomz/fishbun/adapter/view/AlbumListAdapter.kt
Outdated
Show resolved
Hide resolved
FishBun/src/main/java/com/sangcomz/fishbun/adapter/view/AlbumListAdapter.kt
Outdated
Show resolved
Hide resolved
sangcomz
reviewed
Oct 3, 2019
findViewByID method should be called on onCreateViewHolder for performance. Therefore, ViewHolder class has view variable and these are initialized on constructor
PicassoAdapter isn't imported in some source codes. Therefore I add import code to solve the build error
Codecov Report
@@ Coverage Diff @@
## develop #179 +/- ##
==========================================
+ Coverage 0.11% 0.12% +<.01%
==========================================
Files 31 31
Lines 1667 1647 -20
Branches 198 198
==========================================
Hits 2 2
+ Misses 1665 1645 -20
Continue to review full report at Codecov.
|
|
After merging the other PR, there was an overlap. |
|
Some codes were reverted from kotlin to java such as AlbumListAdapter and DetailViewPagerAdapter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #.
N/A
This PR changes:
Next classes are converted from Java to Kotlin
Add kotlin android extensions
Verified
Target Device - LG G7