Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mafft version check still failing - bug in regexp found #360

Closed
tseemann opened this issue Oct 31, 2017 · 1 comment
Closed

mafft version check still failing - bug in regexp found #360

tseemann opened this issue Oct 31, 2017 · 1 comment

Comments

@tseemann
Copy link
Contributor

% roary -a

2017/10/31 11:18:12 Looking for 'mafft' - found /home/linuxbrew/.linuxbrew/bin/mafft
Use of uninitialized value in concatenation (.) or string at /home/linuxbrew/.linuxbrew/Cellar/perl/5.26.1/lib/perl5/site_perl/5.26.1/Bio/Roary/External/CheckTools.pm line 129.
2017/10/31 11:18:12 Determined mafft version is

% mafft --help

------------------------------------------------------------------------------
  MAFFT v7.305b (2016/Aug/16)

The bug is the space at the end of REGEXP ... the b in the version ruins this. You can move the space safely.

    'mafft' => {
        GETVER => "mafft --version < /dev/null 2>&1",
        REGEXP => qr/(\d+\.\d+) /,
        NEEDED => 1,
    },

These hashes look very familiar :-)
We need a central Perl repo for this module which knows all the tools?

@andrewjpage
Copy link
Member

Fixed thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants