Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roary -f OUTDIR is not honoured if OUTDIR exists #404

Open
tseemann opened this issue Jun 14, 2018 · 1 comment
Open

roary -f OUTDIR is not honoured if OUTDIR exists #404

tseemann opened this issue Jun 14, 2018 · 1 comment

Comments

@tseemann
Copy link
Contributor

tseemann commented Jun 14, 2018

It turns out that if you rerun roary with the same -f OUTDIR it will instead put the result in OUTDIR . EPOCH_SECONDS.

I feel this behaviour is helpful in some ways (not lose a big result) but harmful and confusing in others.

Either (1) error with "OUTDIR already exists" or (2) just overwrite it; or (3) allow overwriting with --force option.

PS. This is ISSUE 404 NOT FOUND?

@tseemann tseemann changed the title roary -f OUTDIR is not honoured of OUTDIR exists roary -f OUTDIR is not honoured if OUTDIR exists Jun 14, 2018
@surh
Copy link

surh commented Jul 6, 2018

I also find this behavior problematic. I am trying to use roary with snakemake, but by defining the expected outputs snakemake creates the OUTDIR before running roary, which then creates OUTDIR/EPOCH_SECONDS.

I think adding a --force or --overwrite option is best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants