Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] [ruby] Update rack 3.1.4 → 3.1.6 (patch) #1761

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jul 3, 2024


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

↗️ rack (indirect, 3.1.4 → 3.1.6) · Repo · Changelog

Security Advisories 🚨

🚨 Rack ReDoS Vulnerability in HTTP Accept Headers Parsing

Summary

A Regular Expression Denial of Service (ReDoS) vulnerability exists in the Rack::Request::Helpers module when parsing HTTP Accept headers. This vulnerability can be exploited by an attacker sending specially crafted Accept-Encoding or Accept-Language headers, causing the server to spend excessive time processing the request and leading to a Denial of Service (DoS).

Details

The fix for GHSA-54rr-7fvw-6x8f was not applied to the main branch and thus while the issue was fixed for the Rack v3.0 release series, it was not fixed in the v3.1 release series until v3.1.5.

Release Notes

3.1.6 (from changelog)

  • Fix several edge cases in Rack::Request#parse_http_accept_header's implementation. (#2226, @ioquatix)

3.1.5 (from changelog)

Security

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 6 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added depfu Automatically created by Depfu Technical Debt labels Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (5c84116) to head (bf63c5d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1761   +/-   ##
========================================
  Coverage    91.36%   91.36%           
========================================
  Files          372      372           
  Lines         7664     7664           
========================================
  Hits          7002     7002           
  Misses         662      662           
Flag Coverage Δ
javascript 93.65% <ø> (ø)
pull_request 91.36% <ø> (?)
push 91.36% <ø> (ø)
ruby 91.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Jul 3, 2024

Code Climate has analyzed commit bf63c5d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.0% (0.0% change).

View more on Code Climate.

@yoldas yoldas self-assigned this Jul 3, 2024
@yoldas yoldas merged commit e148df6 into develop Jul 3, 2024
14 checks passed
@yoldas yoldas deleted the depfu/update/rack-3.1.6 branch July 3, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depfu Automatically created by Depfu Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant