Add a if-statement at build_spec checking add default 200 response or not. #116
Conversation
The if-statement is to check a responses is empty or not to decide add a de- fault 200 response or not.
There was a problem hiding this comment.
Hi @jackey8616,
First, thanks for your contribution, here are something I need your help to merge this PR:
-
You change the default behavior of adding default 200 response to swagger. This is a good point, but you forget to modify the current tests. Could you fix the tests? About how to run tests at local development you can check this to get more information.
-
This project uses
blackas default coding style. Could you also apply it? Here are some instructions.
BTW, I've noticed that you are from Taiwan and study in Yuntech. So was I. XD
Fix test case at test_response with removing default 200 status code. But test_swagger_endpoint_redirect still have a status code 302, not sure what this for.
|
@chenjr0719 And, what a small world. lol. 😆 |
|
@jackey8616 |
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 95.43% 95.45% +0.02%
==========================================
Files 4 4
Lines 438 440 +2
Branches 93 94 +1
==========================================
+ Hits 418 420 +2
Misses 6 6
Partials 14 14
Continue to review full report at Codecov.
|
|
@chenjr0719 , |
The if-statement is to check a responses is empty or not to decide add a default 200 response or not.