Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a if-statement at build_spec checking add default 200 response or not. #116

Merged
merged 3 commits into from
Jul 2, 2019
Merged

Add a if-statement at build_spec checking add default 200 response or not. #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d8d7d0
Add a if-statement when build_spec method
jackey8616 Jun 27, 2019
eeeb892
Fit black codestyle & fix some test case
jackey8616 Jun 30, 2019
e624f44
Merge branch 'master' into master
jackey8616 Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sanic_openapi/swagger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,16 +216,17 @@ def build_spec(app, loop):

route_parameters.append(route_param)

responses = {
"200": {
responses = {}

if len(route_spec.response) == 0:
responses["200"] = {
"schema": serialize_schema(route_spec.produces.field)
if route_spec.produces
else None,
"description": route_spec.produces.description
if route_spec.produces
else None,
}
}

for (status_code, routefield) in route_spec.response:
responses["{}".format(status_code)] = {
Expand Down
5 changes: 1 addition & 4 deletions tests/test_decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,7 @@ def test(request):
"response_args, responses",
[
([], {"200": {}}),
(
[201, {}],
{"200": {}, "201": {"schema": {"type": "object", "properties": {}}}},
),
([201, {}], {"201": {"schema": {"type": "object", "properties": {}}}}),
],
)
def test_response(app, response_args, responses):
Expand Down