Customizable protocol #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemethere
requested changes
Dec 23, 2016
| def serve(host, port, request_handler, error_handler, before_start=None, | ||
| after_start=None, before_stop=None, after_stop=None, | ||
| debug=False, request_timeout=60, sock=None, | ||
| def serve(protocol, host, port, request_handler, error_handler, |
There was a problem hiding this comment.
Would it be smart to put this at the front of the arguments list and possibly break functionality for anyone who uses this? I think putting this at the end and defaulting it to our own HttpProtocol would be better in this case.
|
@seemethere |
seemethere
approved these changes
Dec 24, 2016
seemethere
requested changes
Dec 24, 2016
|
@seemethere |
|
@seemethere |
seemethere
approved these changes
Jan 3, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, the developer can not change the behavior of the protocol.
By implementing a subclass of HttpProtocol and making it an argument of the
runfunction,the developer can change the behavior when data is received and the behavior when an error occurs.
This is related #115 and #208 .