Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX UserWarning when using ASGI mode #2091

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

ZinkLu
Copy link
Member

@ZinkLu ZinkLu commented Mar 26, 2021

get rid of warning when using ASGI server to run sanic.

INFO:     Started server process [69183]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://127.0.0.1:8000 (Press CTRL+C to quit)
./sanic/base.py:35: UserWarning: Setting variables on Sanic instances is deprecated and will be removed in version 21.9. You should change your Sanic instance to use instance.ctx._asgi_app instead.
  warn(
...

@ZinkLu ZinkLu requested a review from a team as a code owner March 26, 2021 10:39
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #2091 (1c0da57) into main (8f06d03) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2091   +/-   ##
=========================================
  Coverage   92.133%   92.133%           
=========================================
  Files           38        38           
  Lines         3470      3470           
  Branches       572       572           
=========================================
  Hits          3197      3197           
  Misses         185       185           
  Partials        88        88           
Impacted Files Coverage Δ
sanic/app.py 92.623% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f06d03...1c0da57. Read the comment docs.

@ahopkins ahopkins merged commit 5ba43de into sanic-org:main Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants