Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate ASGI request and lifespan callables #2646

Merged
merged 7 commits into from
Mar 17, 2023
Merged

Separate ASGI request and lifespan callables #2646

merged 7 commits into from
Mar 17, 2023

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Jan 1, 2023

I noticed some breaks in ASGI implementation. This should largely have no impact on how Sanic performs with ASGI, but creates a cleaner separation between the ASGIApp (which is now exclusively for request handling) and Lifespan (which now has top level treatment in the Sanic.__call__ method).

@ahopkins ahopkins requested a review from a team as a code owner January 1, 2023 08:40
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 91.379% and project coverage change: +0.019 🎉

Comparison is base (08a81c8) 88.587% compared to head (b077fd1) 88.607%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2646       +/-   ##
=============================================
+ Coverage   88.587%   88.607%   +0.019%     
=============================================
  Files           87        87               
  Lines         6817      6820        +3     
  Branches      1172      1171        -1     
=============================================
+ Hits          6039      6043        +4     
  Misses         535       535               
+ Partials       243       242        -1     
Impacted Files Coverage Δ
sanic/app.py 89.752% <75.000%> (-0.301%) ⬇️
sanic/asgi.py 91.538% <94.000%> (-0.770%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins changed the title Begin some fixes for ASGI Separate ASGI request and lifespan callables Mar 16, 2023
Copy link

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sanic/asgi.py Show resolved Hide resolved
@ahopkins ahopkins merged commit 5ee36fd into main Mar 17, 2023
@ahopkins ahopkins deleted the asgi-fixes branch March 17, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants