Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSONResponse default content type #2737

Merged
merged 2 commits into from Apr 9, 2023

Conversation

prryplatypus
Copy link
Member

@prryplatypus prryplatypus commented Apr 9, 2023

Fixes #2736

@prryplatypus prryplatypus requested a review from a team as a code owner April 9, 2023 16:19
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6eaab2a) 88.938% compared to head (93e86b8) 88.938%.

❗ Current head 93e86b8 differs from pull request most recent head 32bd976. Consider uploading reports for the commit 32bd976 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2737   +/-   ##
=========================================
  Coverage   88.938%   88.938%           
=========================================
  Files           92        92           
  Lines         6952      6952           
  Branches      1185      1185           
=========================================
  Hits          6183      6183           
  Misses         527       527           
  Partials       242       242           
Impacted Files Coverage Δ
sanic/response/types.py 84.831% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit af67801 into main Apr 9, 2023
30 checks passed
@ahopkins ahopkins deleted the json-response-default-content-type branch April 9, 2023 19:23
ahopkins pushed a commit that referenced this pull request Jul 10, 2023
Fix JSONResponse default content type (#2737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONResponse defaults to None content-type
2 participants