Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSONResponse default content type #2738

Merged
merged 3 commits into from Jul 10, 2023

Conversation

prryplatypus
Copy link
Member

Fixes #2736 on LTS

@prryplatypus prryplatypus requested a review from a team as a code owner April 10, 2023 08:27
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.060 ⚠️

Comparison is base (4ad8168) 88.650% compared to head (6b9c1cc) 88.591%.

❗ Current head 6b9c1cc differs from pull request most recent head 6d08353. Consider uploading reports for the commit 6d08353 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           22.12LTS     #2738       +/-   ##
==============================================
- Coverage    88.650%   88.591%   -0.060%     
==============================================
  Files            82        82               
  Lines          6767      6767               
  Branches       1156      1156               
==============================================
- Hits           5999      5995        -4     
- Misses          531       533        +2     
- Partials        237       239        +2     
Impacted Files Coverage Δ
sanic/response/types.py 84.705% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@prryplatypus
Copy link
Member Author

Linter errors seem unrelated

@ahopkins
Copy link
Member

ahopkins commented Jul 9, 2023

Can we get the linter issue fixed?

@prryplatypus
Copy link
Member Author

Can we get the linter issue fixed?

Done. Apparently just had to run black :)

@ahopkins ahopkins merged commit fc82b23 into 22.12LTS Jul 10, 2023
30 checks passed
@ahopkins ahopkins deleted the json-response-default-content-type branch July 10, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants