Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(listen): lazy init event source #181

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix(listen): lazy init event source #181

merged 1 commit into from
Mar 30, 2023

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Mar 28, 2023

Reduces bundle size for environments which doesn't use client.listen.
Also helps cases like #177.

Can be tested using: npm i --save-exact @sanity/client@lazy-event-source.

Build output diff: https://app.renovatebot.com/package-diff?name=@sanity/client&from=5.4.0&to=5.4.1-lazy-event-source.0

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, lgtm!

package.json Show resolved Hide resolved
@stipsan stipsan merged commit a84ee1c into main Mar 30, 2023
@stipsan stipsan deleted the lazy-event-source branch March 30, 2023 12:15
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants