Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix default portal domain #8

Merged
merged 1 commit into from
Oct 5, 2022
Merged

fix: fix default portal domain #8

merged 1 commit into from
Oct 5, 2022

Conversation

sjelfull
Copy link
Member

@sjelfull sjelfull commented Aug 19, 2022 •
edited
Loading

Fixes #6

@sjelfull sjelfull requested a review from runeb August 19, 2022 14:13
runeb
runeb approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@runeb runeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with version 3 of the compact view, but assume the callback etc work the same as in version 2 and that asset picking has been tested.

@runeb runeb merged commit 494f560 into main Oct 5, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runeb runeb runeb approved these changes

Assignees
No one assigned
Labels
released on @studio-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bynder-input.json's portalDomain not doing anything
2 participants
@sjelfull @runeb