fix(sanity): ignore sticky overlay regions with a falsey DOM node (#6910

)
sanity-io · Jun 13, 2024 · 4f1be6c · 4f1be6c · ahmedrowaihi · Jun 15, 2024
1 parent 911ebfd
commit 4f1be6c
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/packages/sanity/src/core/presence/overlay/StickyOverlay.tsx b/packages/sanity/src/core/presence/overlay/StickyOverlay.tsx
@@ -137,11 +137,17 @@ function regionsWithComputedRects(
   regions: ReportedPresenceData[],
   parent: HTMLElement,
 ): ReportedRegionWithRect<FieldPresenceData>[] {
-  return regions.map(([id, region]) => ({
-    ...region,
-    id,
-    rect: getRelativeRect(region.element, parent),
-  }))
+  return (
+    regions
+      // Note: This filter shouldn't be necessary, but some developers have experienced regions
+      // being passed to the function with a `null` element.
+      .filter(([, region]) => Boolean(region.element))
+      .map(([id, region]) => ({
+        ...region,
+        id,
+        rect: getRelativeRect(region.element, parent),
+      }))
+  )
 }
 
 type Props = {margins: Margins; children: ReactNode}