Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vision] Fix scroll issues #1295

Merged
merged 4 commits into from
May 23, 2019
Merged

[vision] Fix scroll issues #1295

merged 4 commits into from
May 23, 2019

Conversation

kristofferjs
Copy link
Contributor

  • Updated codemirror
  • Use raw css to avoid a lot of :global in css
  • Set heigh as props on resize

@kristofferjs kristofferjs requested a review from rexxars May 14, 2019 11:05
@kristofferjs
Copy link
Contributor Author

Found a new bug. on hold

@kristofferjs kristofferjs changed the title [vision] Update codemirror, use raw css and height props [vision] Fix scroll issues May 15, 2019
@kristofferjs kristofferjs mentioned this pull request May 20, 2019
Merged
rexxars
rexxars requested changes May 23, 2019
View reviewed changes
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I don't see lodash actually being used, though? Should that be removed?

@kristofferjs
Copy link
Contributor Author

Oh. probably yes. Will fix

@kristofferjs kristofferjs force-pushed the vision-plugin-scrolling-issues branch from 0d9de3e to e40d073 Compare May 23, 2019 14:09
@kristofferjs
Copy link
Contributor Author

done

rexxars
rexxars approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kristofferjs kristofferjs force-pushed the vision-plugin-scrolling-issues branch from e40d073 to 3565b48 Compare May 23, 2019 15:10
@kristofferjs kristofferjs merged commit b8695a7 into next May 23, 2019
@kristofferjs kristofferjs deleted the vision-plugin-scrolling-issues branch May 23, 2019 15:10
bjoerge pushed a commit that referenced this pull request Aug 13, 2019
@bjoerge
[vision] Fix scroll issues (#1295)
4b4031e 
* [vision] Update codemirror, use raw css and height props

* [vision] Adding css for hint

* [vision] Different sollution

* [vision] Removing lodash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexxars rexxars rexxars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kristofferjs @rexxars