Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vision] Faster result view #1298

Merged
merged 5 commits into from
May 23, 2019
Merged

[vision] Faster result view #1298

merged 5 commits into from
May 23, 2019

Conversation

kristofferjs
Copy link
Contributor

No description provided.

@kristofferjs kristofferjs requested a review from rexxars May 15, 2019 08:37
@kristofferjs
Copy link
Contributor Author

Based on #1295 (Rebase against next after merging)

Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/SanityVision.js still references css/jsonInspector.css, so removing this file breaks the build

@kristofferjs
Copy link
Contributor Author

fixed

@rexxars
Copy link
Member

rexxars commented May 23, 2019

👍

@rexxars rexxars changed the title Vision faster result view [vision] Faster result view May 23, 2019
@kristofferjs kristofferjs merged commit 9f61ab5 into next May 23, 2019
@kristofferjs kristofferjs deleted the vision-faster-result-view branch May 23, 2019 15:03
bjoerge pushed a commit that referenced this pull request Aug 13, 2019
* [vision] Update codemirror, use raw css and height props

* [vision] Adding css for hint

* [vision] Removing duplicate code and groupArraysAfterLength

* [vision] Remove old css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants