Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[selects/searchable-style] add pointer-events: none to noResultTextHidden to fix it blocking the scrollbar #2138

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

Aratramba
Copy link
Contributor

@Aratramba Aratramba commented Nov 18, 2020

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe:

Does this change require a documentation update? (Check one)

  • Yes
  • No

Current behavior

The top part of the searchable select scrollbar is unusable with the mouse because of an overlaying hidden div with the 'no results' message.

Screenshot 2020-11-18 at 08 26 30

searchable-dropdown-not-scrollable

Description

The hidden text should either be made unusable with pointer-events: none or completely hidden and out of the way (other than with opacity), for example with a transform: scale(0).

Note for release

Fixed a bug where the top part of the searchable select dropdown scrollbar was being blocked by a hidden div.

Checklist

  • I have read the Contributing Guidelines
  • The PR title includes a link to the relevant issue
  • The PR title is appropriately formatted: [some-package] PR title (#123)
  • The code is linted
  • The test suite is passing
  • Corresponding changes to the documentation have been made

to fix it blocking the scrollbar
@vercel
Copy link

vercel bot commented Nov 18, 2020

@Aratramba is attempting to deploy a commit to the Sanity Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@mariuslundgard mariuslundgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome – thank you! 🙏

@vercel
Copy link

vercel bot commented Nov 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sanity-io/test-studio/6l9mq324u
✅ Preview: https://test-studio-git-patch-1.sanity-io.vercel.app

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants