Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base] New form field components #2229

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

mariuslundgard
Copy link
Member

@mariuslundgard mariuslundgard commented Jan 19, 2021

Type of change (check at least one)

  • New feature (non-breaking change which adds functionality)

Does this change require a documentation update? (Check one)

  • No (but it will soon)

Description

This change introduces 4 new public components for building form field components:

import {
  FormField,
  FormFieldHeaderText,
  FormFieldSet,
  FormFieldValidationStatus,
} from '@sanity/base/components'

Note for release

  • New building blocks for composing form fields, that will be used by @sanity/form-builder and to create custom input components.

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #1502: [base] New FormField components.

@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch from a663c3f to c9bd83f Compare January 19, 2021 13:05
@vercel
Copy link

vercel bot commented Jan 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sanity-io/test-studio/40fanttad/sanity.build
✅ Preview: https://test-studio-git-ui-ch1502base-new-formfield-components.sanity.build

@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch from c9bd83f to 25fdea3 Compare January 19, 2021 13:10
@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch from 651afa9 to bea751a Compare January 19, 2021 16:05
@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch 2 times, most recently from 8a72de8 to f97eb12 Compare January 19, 2021 16:09
@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch from f97eb12 to c0c43af Compare January 19, 2021 16:38
@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch from c0c43af to ab08464 Compare January 19, 2021 17:01
@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch from ab08464 to 920e8e6 Compare January 19, 2021 17:31
@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch from 920e8e6 to f369986 Compare January 19, 2021 17:38
@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch from f369986 to dc1e699 Compare January 19, 2021 17:39
@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch from dc1e699 to b44d278 Compare January 20, 2021 09:01
@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch from b44d278 to a8b2790 Compare January 20, 2021 09:17
@mariuslundgard mariuslundgard force-pushed the ui/ch1502/base-new-formfield-components branch from a8b2790 to c8be4ee Compare January 20, 2021 09:19
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions about a couple of minor things that was a bit unclear to me while reading through. Otherwise LGTM!

@mariuslundgard mariuslundgard merged commit 734dc2d into next Jan 20, 2021
@mariuslundgard mariuslundgard deleted the ui/ch1502/base-new-formfield-components branch January 20, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants